Skip to content

feat: add additional fields for connection tracing #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2023
Merged

feat: add additional fields for connection tracing #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/common/src/aws/sdk/kotlin/crt/http/HttpClientConnection.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,15 @@ import aws.sdk.kotlin.crt.Closeable
/**
* This class wraps aws-c-http to provide the basic HTTP request/response functionality via the AWS Common Runtime.
*
* HttpClientConnection represents a single connection to a HTTP service endpoint.
* HttpClientConnection represents a single connection to an HTTP service endpoint.
*
* This class is not thread safe and should not be called from different threads.
*/
public interface HttpClientConnection : Closeable {
/**
* The unique ID of this connection.
*/
public val id: String

/**
* Schedules an HttpRequest on the Native EventLoop for this HttpClientConnection.
Expand Down
1 change: 1 addition & 0 deletions src/jvm/src/aws/sdk/kotlin/crt/http/HttpClientConnectionJVM.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import software.amazon.awssdk.crt.http.HttpClientConnection as HttpClientConnect
* Wrapper around JNI HttpClientConnection type that implements the expected KMP interface
*/
internal class HttpClientConnectionJVM constructor(internal val jniConn: HttpClientConnectionJni) : HttpClientConnection {
override val id: String = jniConn.nativeHandle.toString()

override fun makeRequest(httpReq: HttpRequest, handler: HttpStreamResponseHandler): HttpStream {
val jniStream = jniConn.makeRequest(httpReq.into(), handler.asJniStreamResponseHandler())
Expand Down