chore: relocate brazil transform #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajtodd
added
the
no-changelog
|
lauzadis
approved these changes
Jan 8, 2024
Comment on lines
+6
to
+7
| "org.jetbrains.kotlinx:atomicfu-jvm:0.23.1": "AtomicfuJvm-0.23.1", | ||
| "org.jetbrains.kotlinx:atomicfu:0.23.1": "Atomicfu-0.23.1", |
Member
There was a problem hiding this comment.
Atomicfu dependencies should not be necessary, while testing did you see these as required?
Contributor
Author
There was a problem hiding this comment.
No probably a miss but I imagine we may need them for KMP support. We can remove for now though
ianbotsf
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
refactor: Add a new
.brazil.jsonfile with the transform logic for justaws-sdk-kotlin. NOTE: This will not take effect until we release a new version ofkatand update the release pipeline to use it. Until then the "global" transform config from repo tools is still the one being used. I tested this locally already and diffed the transform output using the one from repo tools and this new localized copyBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.