Skip to content

Conversation

@Plazmius
Copy link

Description

Add handling for StringList parameters, which is a type of parameter, supported by AWS SSM

Motivation and Context

This addresses #48

Testing

I have run unit and integration tests and used this code in my project

Screenshots (if appropriate)

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

While tests are passing, I think whoever is using DefaultParameterProcessor won't expect that StringList are now handled differently. However, I would expect that one of only three SSM parameters type would convert to collection automatically.

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

Not sure that this feature fits the current test structure, but old tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@BradKnowles
Copy link

Thank you for this! I used your code to create a custom StringListParameterProcessor, inheriting from DefaultParameterProcessor and it worked perfectly.

@ashishdhingra ashishdhingra added feature-request A feature should be added or improved. module/sys-mgr-ext p1 This is a high priority issue queued labels Sep 1, 2023
@dscpinheiro dscpinheiro changed the base branch from master to dev September 6, 2023 15:47
Copy link
Contributor

@ashishdhingra ashishdhingra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes work fine while adjusting and executing sample application in this repo. Sample data returned using Get endpoint:

{"settings":{"stringValue":"string-value","integerValue":10,"dateTimeValue":"2000-01-01T00:00:00","booleanValue":true,"timeSpanValue":"00:05:00","stringValues":["White","Yellow","Green","Black"]}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-request A feature should be added or improved. module/sys-mgr-ext p1 This is a high priority issue queued

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants