Conversation
Removed GITFARM_PACKAGE_NAME from required secrets.
Removed GITFARM_PACKAGE_NAME from secrets in sync-sdk workflow.
Removed GITFARM_PACKAGE_NAME from secrets in sync-testing-sdk.yml.
Updated S3 file path and payload for Gitfarm commit.
added space in aws-durable-execution-sdk-java pom.xml to trigger sdk sync
| <module>aws-durable-execution-sdk-java</module> | ||
| <module>aws-durable-execution-sdk-java-testing</module> | ||
| <module>sdk-integration-tests</module> | ||
| <module>examples</module> |
There was a problem hiding this comment.
I think renaming the modules isn't necessary, is it?
There was a problem hiding this comment.
I was testing the GitHub Workflow that I've committed. It is triggered by a commit. We can squash this prior to merging in the GitHub console.
There was a problem hiding this comment.
and yeah, renaming the modules isn't necessary
There was a problem hiding this comment.
I see that some repos are using long module names:
https://github.com/aws/aws-sdk-java/blob/master/pom.xml#L36
But it looks like newer repos are using shorter module names, e.g.
https://github.com/aws/aws-sdk-java-v2/blob/master/pom.xml
So I lean to keeping the current names.
There was a problem hiding this comment.
I personally think that using that having exact module names that match what the respective packages will be called is the best customer experience. I can disagree and commit here.
|
Why does this PR have so many commits? |
|
tested with old module names here's the successful runs: sdk: https://github.com/aws/aws-durable-execution-sdk-java/actions/runs/21299214724 |
sync sdk and sdk testing internally --------- Co-authored-by: hsilan <hsilan@amazon.com>
3 participants
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
Description
Adding automation to sync commits made to sdk and testing sdk internally.
Demo/Screenshots
Checklist
Testing
I ran the workflow for both SDK and testing SDK:
Unit Tests
Have unit tests been written for these changes?
n/a
Integration Tests
Have integration tests been written for these changes?
n/a
Examples
Has a new example been added for the change? (if applicable)
n/a