Merged
Conversation
zhongkechen
reviewed
Jan 23, 2026
examples/src/main/java/com/amazonaws/lambda/durable/examples/CallbackExample.java
Outdated
Show resolved
Hide resolved
zhongkechen
reviewed
Jan 23, 2026
zhongkechen
reviewed
Jan 23, 2026
sdk/src/main/java/com/amazonaws/lambda/durable/exception/CallbackFailedException.java
Show resolved
Hide resolved
phipag
previously requested changes
Jan 26, 2026
Contributor
phipag
left a comment
There was a problem hiding this comment.
Awesome work, and the cloud based tests also pass for me when deployed to my account. These comments are mostly cosmetic / minor. No major concerns about merging this.
examples/src/main/java/com/amazonaws/lambda/durable/examples/CallbackExample.java
Outdated
Show resolved
Hide resolved
examples/src/main/java/com/amazonaws/lambda/durable/examples/CallbackExample.java
Outdated
Show resolved
Hide resolved
examples/src/test/java/com/amazonaws/lambda/durable/examples/CloudBasedIntegrationTest.java
Outdated
Show resolved
Hide resolved
examples/src/test/java/com/amazonaws/lambda/durable/examples/CloudBasedIntegrationTest.java
Outdated
Show resolved
Hide resolved
examples/src/test/java/com/amazonaws/lambda/durable/examples/CloudBasedIntegrationTest.java
Show resolved
Hide resolved
sdk-testing/src/main/java/com/amazonaws/lambda/durable/testing/CloudDurableTestRunner.java
Show resolved
Hide resolved
sdk-testing/src/main/java/com/amazonaws/lambda/durable/testing/HistoryEventProcessor.java
Outdated
Show resolved
Hide resolved
sdk-testing/src/main/java/com/amazonaws/lambda/durable/testing/HistoryEventProcessor.java
Outdated
Show resolved
Hide resolved
sdk-testing/src/main/java/com/amazonaws/lambda/durable/testing/HistoryEventProcessor.java
Outdated
Show resolved
Hide resolved
sdk-testing/src/main/java/com/amazonaws/lambda/durable/testing/LocalMemoryExecutionClient.java
Show resolved
Hide resolved
zhongkechen
reviewed
Jan 26, 2026
sdk/src/main/java/com/amazonaws/lambda/durable/operation/CallbackOperation.java
Show resolved
Hide resolved
* add a method to construct TypeToken from Class * remove resultType from StepOperation * fix tests and examples * revert the accidental changes made by IntelliJ
86fb96e to
9d6f429
Compare
Contributor
Author
|
@zhongkechen and @phipag applied review comments. please take a look. |
Contributor
|
Code looks good, but the cloud integration tests are failing now. I think related to refactoring to |
Contributor
Author
|
Fixed CloudIntegration Tests. Was missing some cases in the new switch when moving from if/else approach |
zhongkechen
approved these changes
Jan 28, 2026
Discussed with Philipp offline and fixed remaining Integration tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
Description
Checklist
Testing
Unit Tests
Have unit tests been written for these changes?
Yes
Integration Tests
Have integration tests been written for these changes?
Yes
Examples
Has a new example been added for the change? (if applicable)
Yes