Merged
Conversation
zhongkechen
reviewed
Mar 12, 2026
sdk/src/main/java/software/amazon/lambda/durable/operation/WaitForConditionOperation.java
Outdated
Show resolved
Hide resolved
|
|
||
| CompletableFuture.runAsync( | ||
| () -> { | ||
| setCurrentThreadContext(new ThreadContext(threadId, ThreadType.STEP)); |
Contributor
There was a problem hiding this comment.
This now happens inside StepContext
zhongkechen
reviewed
Mar 12, 2026
sdk/src/main/java/software/amazon/lambda/durable/operation/WaitForConditionOperation.java
Show resolved
Hide resolved
nvasiu
force-pushed
the
wait_for_condition
branch
from
7c5dea5 to
92d9262
Compare
nvasiu
force-pushed
the
wait_for_condition
branch
from
92d9262 to
ccbd77f
Compare
zhongkechen
reviewed
Mar 17, 2026
| private final T initialState; | ||
| private final SerDes serDes; // nullable, falls back to DurableConfig default | ||
|
|
||
| public static <T> Builder<T> builder(WaitForConditionWaitStrategy<T> waitStrategy, T initialState) { ... } |
Contributor
There was a problem hiding this comment.
Are they optional? If not, shouldn't they be the parameters of waitForCondition method?
zhongkechen
approved these changes
Mar 17, 2026
Contributor
|
Merging now to integrate changes early, avoid more conflicts and allow to start tests by broader audiences |
zhongkechen
reviewed
Mar 17, 2026
| try { | ||
| currentState = deserializeResult(checkpointData); | ||
| } catch (Exception e) { | ||
| currentState = config.initialState(); |
Contributor
There was a problem hiding this comment.
I think an exception should be thrown instead of falling back to initial state
zhongkechen
reviewed
Mar 17, 2026
|
|
||
| // Serialize/deserialize round-trip to ensure state is checkpoint-safe | ||
| var serializedState = serializeResult(newState); | ||
| T deserializedState = deserializeResult(serializedState); |
Contributor
There was a problem hiding this comment.
Should we do the same for initialState?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
#90
Description
Initial commit of new waitForCondition operation (not including tests).
WORK IN PROGRESS
Demo/Screenshots
WIP
Checklist
Testing
Unit Tests
Have unit tests been written for these changes?
Yes
Integration Tests
Have integration tests been written for these changes?
Yes
Examples
Has a new example been added for the change? (if applicable)
Yes