[feat: invoke] initial invoke implementation#20
Conversation
phipag
left a comment
There was a problem hiding this comment.
Only some minor nits picks / comments. Looks like a great start.
One note regarding the formatting. We setup Spotless for formatting. Before pushing you can run:
mvn spotless:apply
which will apply the common formatting we have (and also add license headers automatically).
You can automate this with a git commit hook which can be setup using:
mvn spotless:install-git-pre-push-hook
sdk/src/main/java/com/amazonaws/lambda/durable/InvokeConfig.java
Outdated
Show resolved
Hide resolved
sdk/src/main/java/com/amazonaws/lambda/durable/InvokeConfig.java
Outdated
Show resolved
Hide resolved
sdk/src/main/java/com/amazonaws/lambda/durable/operation/InvokeOperation.java
Outdated
Show resolved
Hide resolved
sdk/src/main/java/com/amazonaws/lambda/durable/operation/InvokeOperation.java
Show resolved
Hide resolved
sdk/src/main/java/com/amazonaws/lambda/durable/operation/InvokeOperation.java
Outdated
Show resolved
Hide resolved
sdk/src/main/java/com/amazonaws/lambda/durable/operation/InvokeOperation.java
Show resolved
Hide resolved
sdk/src/main/java/com/amazonaws/lambda/durable/exception/InvokeFailedException.java
Outdated
Show resolved
Hide resolved
maschnetwork
left a comment
There was a problem hiding this comment.
Some minor comments on naming and switch case for .get
sdk/src/main/java/com/amazonaws/lambda/durable/exception/InvokeFailedException.java
Outdated
Show resolved
Hide resolved
sdk/src/main/java/com/amazonaws/lambda/durable/operation/InvokeOperation.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Philipp Page <pagejep@amazon.com>
Co-authored-by: Philipp Page <pagejep@amazon.com>
@phipag That's great! I didn't know Spoltless is used. Is there an IntelliJ plugin for it? |
…eOperation.java Co-authored-by: Philipp Page <pagejep@amazon.com>
There is this plugin: https://plugins.jetbrains.com/plugin/22455-spotless-applier. Note that some plugins only work with Gradle but not Maven. We chose it mainly because it is IDE independent + has a CLI that can be used in a GitHub action to lint code style and also license headers. |
maschnetwork
left a comment
There was a problem hiding this comment.
See comments. Please also add end user docs to README.
sdk-integration-tests/src/test/java/com/amazonaws/lambda/durable/InvokeIntegrationTest.java
Outdated
Show resolved
Hide resolved
examples/src/main/java/com/amazonaws/lambda/durable/examples/SimpleInvokeExample.java
Show resolved
Hide resolved
sdk-testing/src/main/java/com/amazonaws/lambda/durable/testing/LocalDurableTestRunner.java
Outdated
Show resolved
Hide resolved
sdk/src/main/java/com/amazonaws/lambda/durable/exception/InvokeFailedException.java
Outdated
Show resolved
Hide resolved
sdk/src/main/java/com/amazonaws/lambda/durable/operation/InvokeOperation.java
Outdated
Show resolved
Hide resolved
sdk-testing/src/main/java/com/amazonaws/lambda/durable/testing/LocalMemoryExecutionClient.java
Outdated
Show resolved
Hide resolved
sdk/src/test/java/com/amazonaws/lambda/durable/operation/InvokeOperationTest.java
Show resolved
Hide resolved
Add a commit to update README, although I think we need to move the SDK tutorial to a separate doc |

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
#18
Description
Implement the chained invocation feature
Demo/Screenshots
Deployed to Lambda and the happy case succeeded
Checklist
Testing
Unit Tests
Have unit tests been written for these changes? Yes
Integration Tests
Have integration tests been written for these changes? Yes
Examples
Has a new example been added for the change? (if applicable) Yes