Skip to content

[feat: invoke] initial invoke implementation#20

Merged
zhongkechen merged 13 commits intomainfrom
invoke
Jan 29, 2026
Merged

[feat: invoke] initial invoke implementation#20
zhongkechen merged 13 commits intomainfrom
invoke

Conversation

@zhongkechen
Copy link
Contributor

@zhongkechen zhongkechen commented Jan 26, 2026

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Issue Link, if available

#18

Description

Implement the chained invocation feature

Demo/Screenshots

Deployed to Lambda and the happy case succeeded

image

Checklist

  • I have filled out every section of the PR template
  • I have thoroughly tested this change

Testing

Unit Tests

Have unit tests been written for these changes? Yes

Integration Tests

Have integration tests been written for these changes? Yes

Examples

Has a new example been added for the change? (if applicable) Yes

@zhongkechen zhongkechen changed the title initial invoke implementation [feat: invoke]initial invoke implementation (WIP) Jan 26, 2026
@zhongkechen zhongkechen self-assigned this Jan 26, 2026
@zhongkechen zhongkechen changed the title [feat: invoke]initial invoke implementation (WIP) [feat: invoke]initial invoke implementation [WIP] Jan 26, 2026
@zhongkechen zhongkechen added work in progress enhancement New feature or request labels Jan 26, 2026
@zhongkechen zhongkechen requested a review from SilanHe January 26, 2026 23:56
Copy link
Contributor

@phipag phipag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some minor nits picks / comments. Looks like a great start.

One note regarding the formatting. We setup Spotless for formatting. Before pushing you can run:

mvn spotless:apply

which will apply the common formatting we have (and also add license headers automatically).

You can automate this with a git commit hook which can be setup using:

mvn spotless:install-git-pre-push-hook 

Copy link
Contributor

@maschnetwork maschnetwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments on naming and switch case for .get

zhongkechen and others added 2 commits January 27, 2026 09:54
Co-authored-by: Philipp Page <pagejep@amazon.com>
Co-authored-by: Philipp Page <pagejep@amazon.com>
@zhongkechen
Copy link
Contributor Author

We setup Spotless for formatting

@phipag That's great! I didn't know Spoltless is used. Is there an IntelliJ plugin for it?

@zhongkechen zhongkechen marked this pull request as ready for review January 27, 2026 21:26
@zhongkechen zhongkechen changed the title [feat: invoke]initial invoke implementation [WIP] [feat: invoke]initial invoke implementation Jan 27, 2026
@zhongkechen zhongkechen changed the title [feat: invoke]initial invoke implementation [feat: invoke] initial invoke implementation Jan 27, 2026
@phipag
Copy link
Contributor

phipag commented Jan 28, 2026

We setup Spotless for formatting

@phipag That's great! I didn't know Spoltless is used. Is there an IntelliJ plugin for it?

There is this plugin: https://plugins.jetbrains.com/plugin/22455-spotless-applier. Note that some plugins only work with Gradle but not Maven.

We chose it mainly because it is IDE independent + has a CLI that can be used in a GitHub action to lint code style and also license headers.

Copy link
Contributor

@maschnetwork maschnetwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. Please also add end user docs to README.

@zhongkechen
Copy link
Contributor Author

Ran the cloud-based integration tests again and succeeded

image

@zhongkechen
Copy link
Contributor Author

See comments. Please also add end user docs to README.

Add a commit to update README, although I think we need to move the SDK tutorial to a separate doc

Copy link
Contributor

@maschnetwork maschnetwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongkechen zhongkechen merged commit 18ae802 into main Jan 29, 2026
3 checks passed
@zhongkechen zhongkechen deleted the invoke branch January 29, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants