Merged
Conversation
zhongkechen
changed the title
SilanHe
reviewed
Apr 7, 2026
| * @return true if any operations were advanced, false otherwise | ||
| */ | ||
| public boolean advanceReadyOperations() { | ||
| public boolean advanceTime() { |
Contributor
There was a problem hiding this comment.
nit: why did we rename this?
Contributor
Author
There was a problem hiding this comment.
The name isn't accurate. It transitions not only PENDING -> READY for STEP but also STARTED -> SUCCEEDED for WAIT.
SilanHe
reviewed
Apr 7, 2026
| this.pollInterval = pollInterval; | ||
| this.timeout = timeout; | ||
| this.invocationType = invocationType; | ||
| this.serDes = Objects.requireNonNullElseGet(serDes, JacksonSerDes::new); |
Contributor
There was a problem hiding this comment.
nit: is this now the preferable pattern to overriding the constructor?
Contributor
Author
There was a problem hiding this comment.
We use overloaded factory methods and the constructor is private in this class. It's nicer than we overload both constructors and factory methods
SilanHe
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
#22
Description
CloudDurableTestRunner:withSerDesto configure custom SerDes config for cloud runners. This will be used to serialize input and deserialize outputLocalDurableTestRunner::withOutputTypeto configure the output type for local runnersTestResult::getResult()method for the cases where the result type is knowncompleteCallback,failCallbackandtimeoutCallbackinto onecompleteCallbackmethodTypeToken::fromGenericSuperClassfor extracting real type info from base class.Demo/Screenshots
Checklist
Testing
Unit Tests
Have unit tests been written for these changes?
Integration Tests
Have integration tests been written for these changes?
Examples
Has a new example been added for the change? (if applicable)