Conversation
…vice. Move to ForkJoinPool for SDK internal operations.
… async steps." This reverts commit f3b7710.
| private final DurableLogger durableLogger; | ||
| private final SerDes serDes; | ||
| private final Phaser phaser; | ||
| private final Executor userExecutor; |
Contributor
There was a problem hiding this comment.
Should we change this to ExecutorService to be more flexible?
Contributor
There was a problem hiding this comment.
Do we need the life control of the customer provided executor or other kind of flexibility? I'm afraid more flexibility to SDK means more restrictions to SDK users
Contributor
Author
There was a problem hiding this comment.
For implementing #10 I think it will be helpful to being able to set a timeout on the executor task itself which would be possible with ExecutorService but not Executor.
zhongkechen
reviewed
Jan 30, 2026
sdk/src/main/java/com/amazonaws/lambda/durable/execution/CheckpointBatcher.java
Outdated
Show resolved
Hide resolved
zhongkechen
reviewed
Jan 30, 2026
zhongkechen
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
#31, #12
Description
This PR separates the executor services into user-defined and sdk internal. The user defined executor service is used for the user logic (handler thread and individual operations). The sdk internal executor is used in ExecutionManager and CheckpointBatcher for sending and retrieving operation updates from/to the DAR backend.
The sdk internal executor uses the common fork join pool in Java which auto-scales with the number of CPU cores and implements the work stealing algorithm for efficient distribution of work across available threads.
Demo/Screenshots
Performance test using ManyAsyncStepsExample deployed in AWS account:
Checklist