Skip to content

[refactor] clean up Class type in operations#43

Merged
zhongkechen merged 2 commits intomainfrom
typetoken
Feb 2, 2026
Merged

[refactor] clean up Class type in operations#43
zhongkechen merged 2 commits intomainfrom
typetoken

Conversation

@zhongkechen
Copy link
Contributor

@zhongkechen zhongkechen commented Feb 2, 2026

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Issue Link, if available

A follow up on #19 to further clean up the usage of Class type in operation interface

Description

#19 added a factory method get to TypeToken so that a TypeToken can be constructed from Class

With this new factory method, the constructors with the internal operation class CallbackOperation can be simplified.

Demo/Screenshots

Checklist

  • I have filled out every section of the PR template
  • I have thoroughly tested this change

Testing

Unit Tests

Have unit tests been written for these changes? Updated.

Integration Tests

Have integration tests been written for these changes? No impact

Examples

Has a new example been added for the change? (if applicable) N/A

Tests in local succeeded.

phipag
phipag previously approved these changes Feb 2, 2026
Copy link
Contributor

@phipag phipag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@maschnetwork maschnetwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks!

@zhongkechen zhongkechen merged commit ea8e2cd into main Feb 2, 2026
0 of 9 checks passed
@zhongkechen zhongkechen deleted the typetoken branch February 20, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants