feat: Implement callback for web runner #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangyb-A
force-pushed
the
web_callback
branch
from
d01e471 to
71c01e4
Compare
Contributor
Author
|
I have ran some |
yaythomas
requested changes
Nov 13, 2025
yaythomas
requested changes
Nov 13, 2025
wangyb-A
force-pushed
the
web_callback
branch
3 times, most recently
from
13876ab to
a6c9ff3
Compare
wangyb-A
force-pushed
the
web_callback
branch
from
a6c9ff3 to
f92b5e5
Compare
yaythomas
requested changes
Nov 13, 2025
- Implement async run, send callback for web runner - Unit tests
wangyb-A
force-pushed
the
web_callback
branch
from
f92b5e5 to
ecc8daf
Compare
yaythomas
approved these changes
Nov 13, 2025
bchampp
reviewed
Nov 14, 2025
|
|
||
| def send_callback_success(self, callback_id: str) -> None: | ||
| try: | ||
| self.lambda_client.send_durable_execution_callback_success( |
Member
There was a problem hiding this comment.
We need to update this to support the optional Result field. Same for error on callback failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Dependencies
If this PR requires testing against a specific branch of the Python Language SDK (e.g., for unreleased changes), uncomment and specify the branch below. Otherwise, leave commented to use the main branch.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.