Skip to content

feat(sdk): Log service error and metadata when failing #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yaythomas merged 2 commits into from
Nov 3, 2025
Merged

feat(sdk): Log service error and metadata when failing #112

yaythomas merged 2 commits into from
Nov 3, 2025

Conversation

@PartiallyUntyped
Copy link
Contributor

@PartiallyUntyped PartiallyUntyped commented Oct 31, 2025 •
edited
Loading

Changes:

  • Logs boto3 metadata and errors.
  • Adds GetExecutionStateError for when we fail to retrieve state.
  • GetExecutionStateError forces additional invokes from dataplane.
  • Adds error and metadata to CheckpointError.

@PartiallyUntyped PartiallyUntyped changed the title Add request_id to logger via ExecutionInfo singleton feat(sdk): Add request_id to logger via ExecutionInfo singleton Oct 31, 2025
bchampp
bchampp previously approved these changes Oct 31, 2025
View reviewed changes
@PartiallyUntyped PartiallyUntyped changed the title feat(sdk): Add request_id to logger via ExecutionInfo singleton feat(sdk): Add RequestId to logger Oct 31, 2025
@PartiallyUntyped PartiallyUntyped changed the title feat(sdk): Add RequestId to logger feat(sdk): Log service error metadata and errors Oct 31, 2025
@PartiallyUntyped PartiallyUntyped changed the title feat(sdk): Log service error metadata and errors feat(sdk): Log service error and metadata when failing Oct 31, 2025
yaythomas
yaythomas requested changes Oct 31, 2025
View reviewed changes
@PartiallyUntyped PartiallyUntyped force-pushed the request-id-in-logger branch 2 times, most recently from b6a3449 to 16154fe Compare October 31, 2025 18:41
yaythomas
yaythomas requested changes Oct 31, 2025
View reviewed changes
@PartiallyUntyped
feat(sdk): log response metadata for service errors
7b0ec34 
- Logs boto3 metadata and errors via extras
- Adds GetExecutionStateError for when we fail to retrieve state.
- GetExecutionStateError forces additional invokes from dataplane.
- Adds error and metadata to `CheckpointError`.
yaythomas
yaythomas approved these changes Nov 3, 2025
View reviewed changes
This was referenced Nov 3, 2025
Closed
Open
@yaythomas yaythomas merged commit 3aea457 into main Nov 3, 2025
9 checks passed
@yaythomas yaythomas deleted the request-id-in-logger branch November 3, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaythomas yaythomas yaythomas approved these changes

@bchampp bchampp bchampp left review comments

@wangyb-A wangyb-A Awaiting requested review from wangyb-A wangyb-A is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PartiallyUntyped @yaythomas @bchampp