fix(sdk): Completion logic hole and cancelling branches when breaching min successful#126
Merged
fix(sdk): Completion logic hole and cancelling branches when breaching min successful#126
Conversation
ghost
requested review from
Changes: - Adds a test suite that causes the concurrent executor to hang where every item is completed, but there is 1 failure, and fault tolerances and min successful are not given. verify by: `hatch test tests/concurrency_test.py`
yaythomas
previously approved these changes
Nov 7, 2025
ghost
changed the title
bchampp
approved these changes
Nov 7, 2025
yaythomas
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.