Conversation
3fc3f51 to
265a5a1
Compare
| connect_timeout=5, | ||
| read_timeout=50, | ||
| user_agent_extra=f"aws-durable-execution-sdk-python/{__version__}", | ||
| user_agent_extra=f"aws-durable-execution-sdk-python{'-bundledruntime' if _IS_RUNTIME_BUNDLED else ''}/{__version__}", |
There was a problem hiding this comment.
should this -bundledruntime be part of the sdk name or part of the version?
And -bundledruntime sounds weird like the runtime is bundled in SDK. Why don't we simply used -bundled?
There was a problem hiding this comment.
I think it makes sense as part of the name, because the bundled runtime doesn't use a special SDK version.
I can make an update to just say "-bundled".
There was a problem hiding this comment.
Sorry to jump into the conversation, but I would add the AWS_EXECUTION_ENV environment variable here - if not set assume "NA" for example. While this SDK is 100% focused on Lambda and only works with the specific payload sent to Lambda, you never know how creatively customers are using it. In Powertools for AWS Lambda, we identified clients using it on a wide variety of platforms other than Lambda.
But of course, it's just an idea, and I don't know if this affects how you consume this string in the backend.
There was a problem hiding this comment.
agree re the bundling effectively being a version variant. something like aws-durable-execution-sdk-python/v.1.2.3-bundled
There was a problem hiding this comment.
re AWS_EXECUTION_ENV
if exists could be:
# bring your own
aws-durable-execution-sdk-js/1.2.3#nodejs24.x
# bundled
aws-durable-execution-sdk-js/1.2.3-bundled#runtime-nodejs24.x
# no execution env variable, use current interpreter version
aws-durable-execution-sdk-js/1.2.3-bundled#node-v20.19.0
265a5a1 to
fffdbb5
Compare
- Detect whether the SDK is installed under the Lambda runtime path. If so, update the UserAgent header string.
fffdbb5 to
c7da73c
Compare
Issue #, if available:
N/A
Description of changes:
Note: we are waiting to confirm the Lambda bundled runtime SDK path. Do NOT merge this PR until we get confirmation.
Updating the UserAgent header string to indicate whether the SDK is being run within the Lambda bundled runtime.
aws-durable-execution-sdk-python/{version}-bundledBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.