fix: Bump setuptools to patch CVE-2024-6345#828
Merged
sharmabikram merged 3 commits intomasterfrom Apr 27, 2026
Merged
Conversation
Replace setuptools==66.1.1 with setuptools>=75.0 to address CVE-2024-6345. Modernize build command from deprecated 'python setup.py sdist bdist_wheel' to 'python -m build', which requires the build package.
Include dev_requirements in source distribution so the sourcebuildcheck tox environment can find test-requirements.txt in the extracted tarball.
Newer setuptools normalizes package names using underscores instead of hyphens in sdist filenames (PEP 625). Update the glob pattern in source-build-check.sh to match both formats.
lucasmcdonald3
approved these changes
Apr 27, 2026
Comment on lines
+2
to
+3
| setuptools>=75.0 | ||
| build>=1.0 |
There was a problem hiding this comment.
Suggested change
| setuptools>=75.0 | |
| build>=1.0 | |
| setuptools>=75.0,<76 | |
| build>=1.0,<2 |
nit: Ideally we wouldn't automatically pull in a breaking change, this can bite us by making our release workflow fail without us realizing why. (That happened to Jose 1-2 weeks ago.) But not a big deal for this repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace setuptools==66.1.1 with setuptools>=75.0 to address CVE-2024-6345. Modernize build command from deprecated 'python setup.py sdist bdist_wheel' to 'python -m build', which requires the build package.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: