Merged
Conversation
We now verify that the requested region is reachable before caching the KMS client.
bdonlan
force-pushed
the
kms-cache-restore
branch
from
e47a0f8 to
4b85273
Compare
added 3 commits
August 3, 2018 14:01
…lient initialization Note that, while previously we would throw an exception when a MK was requested for a region that the MKP cannot service immediately on MK creation, we now throw on first use of the MK.
bdonlan
force-pushed
the
kms-cache-restore
branch
from
4aa0af8 to
2a6e6e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now verify that the requested region is reachable before caching the KMS
client. Behavior verified by tests (for the should-not-cache case) and log inspection (for the should-cache case).