feat: Browser testing #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Browser testing using Karma * Convert web-crypt-backend test to Karma * add raw-aes-keyring-browser tests * fix raw-aes-keyring-browser providerInfo serialization * add raw-rsa-keyring-browser tests
karlw00t
approved these changes
Jun 18, 2019
mattsb42-aws
approved these changes
Jun 18, 2019
Member
mattsb42-aws
left a comment
mattsb42-aws
left a comment
There was a problem hiding this comment.
finger to the wind LPGTM
AllanZhengYP
approved these changes
Jun 18, 2019
AllanZhengYP
left a comment
AllanZhengYP
left a comment
There was a problem hiding this comment.
Looks good to me! A suggestion is that you can import the global karma config from each subpackages so that you don't need to duplicate all the settings in each of your browser packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.