Multi keyrings #166
Merged
Multi keyrings #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsb42-aws
requested changes
Jul 12, 2019
…to multi-keyrings
mattsb42-aws
requested changes
Jul 22, 2019
Member
mattsb42-aws
left a comment
mattsb42-aws
left a comment
There was a problem hiding this comment.
Code is looking good, with one exception that I missed when I read through before.
Just need to flesh out those tests.
mattsb42-aws
requested changes
Jul 24, 2019
…urther keyrings are called if data encryption key is added
mattsb42-aws
requested changes
Jul 31, 2019
Merged
mattsb42-aws
requested changes
Aug 1, 2019
Member
mattsb42-aws
left a comment
mattsb42-aws
left a comment
There was a problem hiding this comment.
Almost there; just a few more fine points to clean up. :)
mattsb42-aws
previously approved these changes
Aug 2, 2019
Member
mattsb42-aws
left a comment
mattsb42-aws
left a comment
There was a problem hiding this comment.
We're going to merge #165 first, but this looks good to go!
mattsb42-aws
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Dependent on the merging of PRs for base keyring API, keyring materials and raw keyrings.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.