Skip to content

Conversation

@lukemaurer
Copy link

Issue #, if available:

Description of changes:

Externs and a Gradle build file for compiling the encryption SDK to Java.

Also a simple benchmark that generates a 28MB string, encrypts it, decrypts it, and compares to the original plaintext.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Luke Maurer added 5 commits December 12, 2019 16:25
The benchmark is largely the Main testing module, but with a much larger
plaintext and with a timer.

The Java packaging is a little rough; something better could probably be done
with Gradle or somithing simpler than Maven.
It's still a bit rough (no way to avoid regenerating sources every time), but
it works.  Use `gradle jar` to build a jar or `gradle runBench` to run the
benchmark.
Also made the Java Gradle build work better by declaring the inputs and outputs
to the Dafny compilation tasks so that it can skip regenerating sources.
@lavaleri
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: DafnyESDK
  • Commit ID: b059b0b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@MatthewBennington MatthewBennington self-requested a review January 15, 2020 23:24
Copy link

@MatthewBennington MatthewBennington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this successfully builds a Java version, it would be good in add that to buildspec.yml file, for repeatability.

* Java: Use new DafnySequence methods for UByte wrapping

This essentially boxes a byte[] in one big box rather than an array
of (potentially millions of) UByte boxes.

* Java: Adapt to unboxed primitives

Dafny no longer uses Byte (or UByte) in generated Java code.

* Adapt to change in Dafny unboxed-java branch

An array of generic type is now represented as a java.lang.Object
rather than a dafny.Array.

Co-authored-by: Luke Maurer <maurerl@amazon.com>
@lavaleri
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: DafnyESDK
  • Commit ID: 9a61a03
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

robin-aws added 2 commits May 23, 2020 08:46
…to java

# Conflicts:
#	build.gradle
#	src/extern/java/AESEncryption/AES_GCM.java
#	src/extern/java/Arrays/Array.java
#	src/extern/java/BouncyCastleCryptoMac/HMac.java
#	src/extern/java/RSAEncryption/RSA.java
#	src/extern/java/Random/__default.java
#	src/extern/java/Signature/ECDSA.java
#	src/extern/java/UTF8/__default.java
#	src/extern/java/Utils/Util.java
@lavaleri
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: DafnyESDK
  • Commit ID: 4087b72
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@lavaleri
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: DafnyESDK
  • Commit ID: d3693d2
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@lavaleri
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: DafnyESDK
  • Commit ID: 5456b02
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

… into java

# Conflicts:
#	.gitignore
#	EncryptionSDK.sln
#	buildspec.yml
@lavaleri
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: DafnyESDK
  • Commit ID: 4547786
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@lavaleri
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: DafnyESDK
  • Commit ID: f13832b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@lavaleri
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: DafnyESDK
  • Commit ID: 13a6321
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@robin-aws robin-aws changed the title Java and benchmark Simple benchmark Jun 1, 2020
@robin-aws
Copy link
Contributor

I've renamed this from "Java and benchmark" to just "Simple benchmark", since all the Java-related content is being moved to https://github.com/awslabs/aws-encryption-sdk-java-formally-verified

@lavaleri
Copy link
Contributor

lavaleri commented Jun 1, 2020

AWS CodeBuild CI Report

  • CodeBuild project: DafnyESDK
  • Commit ID: 45e9c80
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@robin-aws
Copy link
Contributor

Note this isn't ready to merge yet anyway, as the build is not verifying/running the new file. I'm not convinced this style of benchmarking is a good idea, but I don't want to lose the code.

@farleyb-amazon farleyb-amazon deleted the java branch May 7, 2022 03:59
josecorella pushed a commit to josecorella/aws-encryption-sdk-dafny that referenced this pull request Oct 11, 2023
* chore(polymorph): pull in latest polymorph

* fix: PR Comments

* Add collection of errors to Java

* woops

---------

Co-authored-by: seebees <ryanemer@amazon.com>
josecorella pushed a commit that referenced this pull request Oct 11, 2023
* chore(polymorph): pull in latest polymorph

* fix: PR Comments

* Add collection of errors to Java

* woops

---------

Co-authored-by: seebees <ryanemer@amazon.com>
josecorella pushed a commit that referenced this pull request Oct 11, 2023
* chore(polymorph): pull in latest polymorph

* fix: PR Comments

* Add collection of errors to Java

* woops

---------

Co-authored-by: seebees <ryanemer@amazon.com>
josecorella pushed a commit that referenced this pull request Oct 11, 2023
* chore(polymorph): pull in latest polymorph

* fix: PR Comments

* Add collection of errors to Java

* woops

---------

Co-authored-by: seebees <ryanemer@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants