Shadow initial commit #1081
Merged
Shadow initial commit #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yourslab
reviewed
Jul 27, 2020
- refine implementation for Shadow_MatchTopic - added logs for shadow library - added more negative test cases - added comments to by pass MISRA 5_2, 5_4
Will remove it after shadow demo is merged
abhidixi11
reviewed
Aug 5, 2020
added 2 commits
August 5, 2020 23:06
- rename SHADOW_TOPIC_STRING_TYPE_GET to ShadowTopicStringTypeGet and other enums - fix test case test_Shadow_MacrosString, test_Shadow_MacrosLength miss matched expected/observed for TEST_ASSERT_EQUAL - added logs for BAD parameters - fixed typo
- rename return code SHADOW_STATUS_XXX to SHADOW_XXX - split test cases for invalid parameters into Happy_Path/Invalid_Parameters
Codecov Report
@@ Coverage Diff @@
## development #1081 +/- ##
===============================================
+ Coverage 96.54% 98.31% +1.77%
===============================================
Files 9 4 -5
Lines 5643 1189 -4454
Branches 641 369 -272
===============================================
- Hits 5448 1169 -4279
+ Misses 9 0 -9
+ Partials 186 20 -166
Continue to review full report at Codecov.
|
- fixed 5.4 by shorten the macro names, and used abbreviation for operation, the comments will explain the macro is related to which operation - simplfiy parameters internal function extractThingName - added getShadowOperationString, getShadowOperationLength to avoid indexing into the array with the value of the enum - fixed typo in shadow_utest.c
- fixed grammer issue - remove unused header file
muneebahmed10
approved these changes
Aug 6, 2020
aggarg
approved these changes
Aug 7, 2020
leegeth
pushed a commit
to leegeth/aws-iot-device-sdk-embedded-C
that referenced
this pull request
Aug 27, 2020
* Shadow LTS initial commit: - added shadow library src folder - added utest for shadow to test shadow library APIs and MACROS Co-authored-by: DanielYEHsieh <wnf007z@example.com> Co-authored-by: Hsieh <dhs@amazon.com>
leegeth
pushed a commit
to leegeth/aws-iot-device-sdk-embedded-C
that referenced
this pull request
Aug 28, 2020
* Shadow LTS initial commit: - added shadow library src folder - added utest for shadow to test shadow library APIs and MACROS Co-authored-by: DanielYEHsieh <wnf007z@example.com> Co-authored-by: Hsieh <dhs@amazon.com>
leegeth
pushed a commit
to leegeth/aws-iot-device-sdk-embedded-C
that referenced
this pull request
Aug 31, 2020
* Shadow LTS initial commit: - added shadow library src folder - added utest for shadow to test shadow library APIs and MACROS Co-authored-by: DanielYEHsieh <wnf007z@example.com> Co-authored-by: Hsieh <dhs@amazon.com>
leegeth
pushed a commit
to leegeth/aws-iot-device-sdk-embedded-C
that referenced
this pull request
Sep 1, 2020
* Shadow LTS initial commit: - added shadow library src folder - added utest for shadow to test shadow library APIs and MACROS Co-authored-by: DanielYEHsieh <wnf007z@example.com> Co-authored-by: Hsieh <dhs@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shadow LTS library
Description of changes:
Added Shadow library
utest code
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.