Fix/openssl connect close socket on error #1939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
aggarg
previously approved these changes
Apr 8, 2025
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
aggarg
approved these changes
Apr 8, 2025
rohitmadan07
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1938
Description of changes:
This pull request addresses the issue where the
Openssl_Connectfunction fails to close the socket on error, leading to a file descriptor leak. The following changes have been made:By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.