Fix: parse --count as int in mqtt5_pubsub.py sample #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! We have recently reorganized our samples, , and these changes are now reflected in our latest sample repository. Checkout Closing the PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #643
Description of changes:
Added type=int to the --count argument in mqtt5_pubsub.py so that it is always parsed as an integer.
Explicitly cast args.input_count to int when assigning message_count.
These changes fix a TypeError: '<=' not supported between instances of 'int' and 'str' that occurs when comparing publish_count to message_count.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.