Ktlint upgrade #42
Ktlint upgrade #42
Conversation
| classpath = execKtlintClasspath | ||
| mainClass.set("com.pinterest.ktlint.Main") | ||
| args = lintPaths | ||
| jvmArgs("--add-opens", "java.base/java.lang=ALL-UNNAMED") |
There was a problem hiding this comment.
question: why remove the jvm args just for ktlint?
There was a problem hiding this comment.
Just following the guide on ktlint docs: https://pinterest.github.io/ktlint/latest/install/integrations/#custom-gradle-integration-with-kotlin-dsl
There was a problem hiding this comment.
I would lean towards keeping it since we don't know if it was necessary but I don't feel strongly about it. A good way to test this would be to run ktlint twice, once with and once without
There was a problem hiding this comment.
Sorry, just saw this comment after I already merged the PR. I had already tested with and without the jvmArgs locally, there was no difference. In general I think we should trust our dependencies' onboarding guides and if they end up being incorrect, send them a PR to fix the documentation.
| mainClass.set("com.pinterest.ktlint.Main") | ||
| args = listOf("-F") + lintPaths | ||
| jvmArgs("--add-opens", "java.base/java.lang=ALL-UNNAMED") | ||
| jvmArgs("--add-opens=java.base/java.lang=ALL-UNNAMED") |
There was a problem hiding this comment.
nit/style: the same change could be made in CodeStyle.kt
2 participants
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.