misc: Upgrade to Kotlin 2.1.0 #59
Conversation
| private fun Project.subprojectArtifactSizeMetricsTask(): TaskProvider<CollectArtifactSizeMetrics> = | ||
| tasks.register<CollectArtifactSizeMetrics>("artifactSizeMetrics") { | ||
| group = TASK_GROUP | ||
| onlyIf { tasks.findByName("jvmJar") != null } | ||
| dependsOn(tasks.withType<Jar>()) | ||
| } | ||
| private fun Project.subprojectArtifactSizeMetricsTask(): TaskProvider<CollectArtifactSizeMetrics> = tasks.register<CollectArtifactSizeMetrics>("artifactSizeMetrics") { | ||
| group = TASK_GROUP | ||
| onlyIf { tasks.findByName("jvmJar") != null } | ||
| dependsOn(tasks.withType<Jar>()) | ||
| } |
There was a problem hiding this comment.
Question: I'm noticing a lot of reformatting which lengthens lines past 120 chars. Was this an automated reformat or did you manually make these changes for some reason?
There was a problem hiding this comment.
This was an automated format from ktlint
| tasks.register<SmithyBuildTask>(TASK_GENERATE_SMITHY_PROJECTIONS) { | ||
| group = "codegen" | ||
| dependsOn(generateSmithyBuild) | ||
| resolvedCliClasspath.set(codegenConfig) | ||
| runtimeClasspath.set(codegenConfig) | ||
| buildClasspath.set(codegenConfig) | ||
| smithyBuildConfigs.set(project.files(generateSmithyBuild)) | ||
| } |
There was a problem hiding this comment.
Question: Why were these removed?
There was a problem hiding this comment.
smithy-gradle-plugin was updated in 1.1.0 to make AbstractSmithyCliTask extend Gradle's DefaultTask rather than BaseSmithyTask which previously exposed these fields.
But I now see they have a cliClassPath property to replace resolvedCliClasspath, so I've re-enabled that config. For runtimeClasspath there is a new cliExecutionClasspath, but it defaults to cliClassPath + buildClasspath so I won't re-enable that config.
2 participants
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.