chore: install the kat tool in a dedicated home directory instead of using $PWD #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0marperez
approved these changes
Mar 7, 2025
.github/actions/setup-kat/action.yml
Outdated
| echo "Creating directory for kat tool at $kat_dir" | ||
| mkdir -p "$kat_dir" | ||
| pushd "$kat_dir" |
There was a problem hiding this comment.
Question: Why pushd instead of cd?
There was a problem hiding this comment.
Oh force of habit. In this case I could just use cd instead since I'm not using popd.
lauzadis
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
(none)
Description of changes:
Previously, kat was installed in
$PWDwhich tends to be the path into which repos will be cloned, causing the existing contents to be deleted. To improve resilience and allow kat to be installed before source code is checked out, this PR changes the kat install dir to$HOME/kat. The unzipped binary path is still added to$PATH/$GITHUB_PATHas before so existing workflows should be unaffected.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.