-
Notifications
You must be signed in to change notification settings - Fork 2
feat: release workflow #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.github/workflows/run-release.yml
Outdated
| exit 0 | ||
| fi | ||
| CURRENT_VERSION=$(git tag --sort=-creatordate | head -n 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correctness: What if the latest tag is a -kn variant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-kn variants are temprorary right? How much longer do you think we'll have them for? We can use the version override
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't say for sure when we'll stop using -kn suffixes. But right now if I release a -kn variant, then go to run this new script, won't it crash/misbehave when trying to add 1 to the patch version?
|
Did some last minute cleanup after looking at this, I hadn't in a while. This is ready for review, I shouldn't be making more changes unless requested. |
README.md
Outdated
| 5. Under `Source` connect your GitHub account (Under `Source` -> `Connection Status` you should see "You are connected to GitHub"). | ||
| 7. Specify the tag you created under `Source Version`. | ||
| 8. Start the build. | ||
| 1. Go to this repos GitHub actions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: repos → repo's
| To cut a new release: | ||
|
|
||
| 1. Create a new tag, e.g. `git tag x.y.z`. | ||
| 2. Push the tag up `git push origin x.y.z`. | ||
| 3. Go to the CodeBuild release job hosted in the shared tools account (e.g. `publish-aws-kotlin-repo-tools`). | ||
| 4. Start a build with overrides. | ||
| 5. Under `Source` connect your GitHub account (Under `Source` -> `Connection Status` you should see "You are connected to GitHub"). | ||
| 7. Specify the tag you created under `Source Version`. | ||
| 8. Start the build. | ||
| 1. Go to this repos GitHub actions. | ||
| 2. Locate the release workflow. | ||
| 3. Specify whether the release will be of a kn variant (used for Kotlin Native development). | ||
| 4. If you're doing a minor or major version bump, specify the version override (including "-kn" if a kn variant). | ||
| 5. Run the workflow. | ||
|
|
||
| The workflow will create a tag, push it to this repo and then start a | ||
| CodeBuild release job hosted in the shared tools account (e.g. `publish-aws-kotlin-repo-tools`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Don't remove the old manual instructions entirely. Leave them in the README.md in a subheader, a collapsed section, etc.
.github/workflows/run-release.yml
Outdated
| PATCH_NUMBER=${PATCH%%[^0-9]*} | ||
| PATCH_SUFFIX=${PATCH#$PATCH_NUMBER} | ||
| ((PATCH_NUMBER++)) | ||
| echo "NEW_VERSION=$MAJOR.$MINOR.$PATCH_NUMBER$SUFFIX" >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correctness: $SUFFIX undefined
Issue #, if available:
N/A
Description of changes:
Automates the process of creating tags and running codebuild job for releases.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.