fix: remove deprecated --without option from ruby bundler #808
+34
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#805
^ PR to pin the old version that works.
The issue is that a new version of RubyGems (4.0.0) deprecates the
--withoutoption that we were using to not include test and development dependencies insam build. This caused anysam buildrunning with that version or above to fail.Description of changes
Changed the bundler to not use
--without. Previously,--withoutimplicitly updated thebundlerconfig to have a field likeNow, we set the config directly. This matches with the approach from the documentation.
Description of how you validated changes
After running
pip install -e .in a Python environment, I tried building a Ruby function usingsamdev build(samdevbeing built with the newaws-lambda-builders. I confirmed that the build succeeded and successfully ignored testing dependencies. I also confirmed that this was not the case in the same environment withsam build.I also confirmed that the behavior between old versions of RubyGems was the same as with the new version of
aws-lambda-builders.Finally, I updated the unit tests to reflect the new change.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.