Increase log buffer size to avoid log message from being broken over multiple CWL records #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In the previous PR #1165 logging was switched to write log message to the Lambda telemetry file descriptor so log messages with newlines will not get broken up over multiple CloudWatch Log records. This triggered a side effect that if the log message was greater then the default StreamWriter buffer size the log message would get broken up over multiple writes to the telemetry file descriptor causing the message to be broken up over multiple records.
This change adjust the buffer size of the StreamWriter to match the max size of the CWL record size to avoid unattended message breaks. I have confirmed there was no noticeable affects to cold start time by increasing the buffer size.
Version number of Amazon.Lambda.AspNetCoreServerHosting was increased because it takes a direct dependency on Amazon.Lambda.RuntimeSupport.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.