Fix/error message type name #1207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normj
approved these changes
Jul 26, 2022
ganeshnj
approved these changes
Jul 27, 2022
| if (customerSerializerInstance == null) | ||
| { | ||
| throw LambdaExceptions.ValidationException(Errors.UserCodeLoader.SerializeMissingAttribute, | ||
| _handler.AssemblyName, _handler.MethodName, dataType.FullName); |
Contributor
There was a problem hiding this comment.
slight perf, we should cache the typeof(LambdaSerializerAttribute) in a member to avoid performing same operation. Not ship blocking.
Contributor
Author
There was a problem hiding this comment.
Do you need to cache it? If it runs that code and throws that Exception, it's lights out, fatal error, isn't it?
Member
|
Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
If the LambdaSerializerAttribute is missing, during invocation of function, the error message of "Could not find the LambdaSerializerAttribute on the assembly 'XXX' or method 'XXX' while attempting to deserialize input data of type 'XXX'. To use types other than System.IO.Stream as input/output parameters, the assembly or Lambda function should be annotated with Amazon.Lambda.LambdaSerializerAttribute." incorrectly names "Amazon.Lambda.LambdaSerializerAttribute". Should be "Amazon.Lambda..Core.LambdaSerializerAttribute"
Fixed by using
typeof(LambdaSerializerAttribute).FullName.I see below that my fork master also has the other PR (#1202) in it, so maybe review it first. I guess I need to not merge my changes into my fork/master anymore. Sorry.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.