Skip to content

Conversation

@fennekin23
Copy link
Contributor

Description of changes:
There are some cases when service URL needs to be overridden for SDK client. This will result in setting RegionEndpoint property to null in SDK client config and will cause NullReferenceException in SQS event source background service.

With this change the region is read from SQS queue ARN rather than from SQS client config, which allows to have custom service URL configured for SQS client.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@normj normj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good but can you fix the whitespace change issue so it doesn't look like you changed the entire file.

@fennekin23
Copy link
Contributor Author

The change looks good but can you fix the whitespace change issue so it doesn't look like you changed the entire file.

Sorry, missed this.
Should be fixed now.

"Projects": [
{
"Name": "Amazon.Lambda.TestTool",
"Type": "Minor",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this a Patch instead of Minor?

Copy link
Member

@normj normj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled down the branch to run the tests and found the ConvertSDKToLambdaEventTests class in the Amazon.Lambda.TestTool.UnitTests needs to be updated due to compilation errors with the change to Arn as the type.

@normj normj merged commit 45134fb into aws:master Apr 10, 2025
@normj
Copy link
Member

normj commented Apr 11, 2025

PR was released in version 0.10.1 of Amazon.Lambda.TestTool. Currently the Aspire.Hosting.AWS package is going to default to installing 0.10.0 but if you manually update the installed version of Amazon.Lambda.TestTool then Aspire.Hosting.AWS will recognize a newer version is installed and use that. To manually install run the following command on the command line.

dotnet tool update -g Amazon.Lambda.TestTool

Most likely in the next release of Aspire.Hosting.AWS we will bump up its default version to the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants