-
Notifications
You must be signed in to change notification settings - Fork 494
Add support for optional SQS client region in event source test tool #2041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
normj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good but can you fix the whitespace change issue so it doesn't look like you changed the entire file.
Sorry, missed this. |
| "Projects": [ | ||
| { | ||
| "Name": "Amazon.Lambda.TestTool", | ||
| "Type": "Minor", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make this a Patch instead of Minor?
normj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled down the branch to run the tests and found the ConvertSDKToLambdaEventTests class in the Amazon.Lambda.TestTool.UnitTests needs to be updated due to compilation errors with the change to Arn as the type.
|
PR was released in version Most likely in the next release of |
Description of changes:
There are some cases when service URL needs to be overridden for SDK client. This will result in setting
RegionEndpointproperty tonullin SDK client config and will causeNullReferenceExceptionin SQS event source background service.With this change the region is read from SQS queue ARN rather than from SQS client config, which allows to have custom service URL configured for SQS client.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.