Fix NullReferenceException with structured logging #2132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#2121
Description of changes:
Amazon.Lambda.RuntimeSupportwas lacking null protection if the message template was null and structured logging was enabled.In addition
Amazon.Lambda.Logging.AspNetCorewas logging for the message template by looking at the log state for the key{OriginalFormat}. There are scenarios where there will be no{OriginalFormat}key. For example enabling HttpLogging. I updatedAmazon.Lambda.Logging.AspNetCoreto detect if there was no message template and if there was not one found use the passed in formatter using the state and exception to get a message template.A later enhancement we should do is extend the RuntimeSupport logging API to pass in the other parameters from the message state that are now not going to be in the formatted message template and get them still included in the structured logging. That is a bigger scope then this null fix.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.