Skip to content

fix empty strings as default AttributeValue issue #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
+23 −2
Open

fix empty strings as default AttributeValue issue #2200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .autover/67579ff1-ffb8-4d48-83a8-b774555ec8e8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"Projects": [
{
"Name": "Amazon.Lambda.DynamoDBEvents.SDK.Convertor",
"Type": "Patch",
"ChangelogMessages": [
"Fix Empty Strings converted to null issue."
]
}
]
}
4 changes: 2 additions & 2 deletions Libraries/src/Amazon.Lambda.DynamoDBEvents.SDK.Convertor/DynamodbAttributeValueConvertor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public static Amazon.DynamoDBv2.Model.AttributeValue ConvertToSdkAttribute(this
var sdkAttribute = new Amazon.DynamoDBv2.Model.AttributeValue();

// String
if (!string.IsNullOrEmpty(lambdaAttribute.S))
if (lambdaAttribute.S!=null)
sdkAttribute.S = lambdaAttribute.S;

// Number
Expand Down Expand Up @@ -112,7 +112,7 @@ public static Amazon.DynamoDBStreams.Model.AttributeValue ConvertToSdkStreamAttr
var sdkAttribute = new Amazon.DynamoDBStreams.Model.AttributeValue();

// String
if (!string.IsNullOrEmpty(lambdaAttribute.S))
if (lambdaAttribute.S != null)
sdkAttribute.S = lambdaAttribute.S;

// Number
Expand Down
10 changes: 10 additions & 0 deletions .../Amazon.Lambda.DynamoDBEvents.SDK.Convertor.Tests/DynamodbAttributeValueConvertorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,16 @@ public void ConvertToSdkAttribute_StringValue_ReturnsSdkAttribute()
Assert.Equal("TestString", sdkAttribute.S);
}

[Fact]
public void ConvertToSdkAttribute_EmptyStringValue_ReturnsSdkAttribute()
{
var lambdaAttribute = new DynamoDBEvent.AttributeValue { S = string.Empty };
var sdkAttribute = lambdaAttribute.ConvertToSdkAttribute();

Assert.NotNull(sdkAttribute);
Assert.Equal(string.Empty, sdkAttribute.S);
}

[Fact]
public void ConvertToSdkAttribute_NumberValue_ReturnsSdkAttribute()
{
Expand Down
Loading