Replace SimStream with DuplexStream #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbarsky
suggested changes
Feb 13, 2021
Contributor
davidbarsky
left a comment
davidbarsky
left a comment
There was a problem hiding this comment.
This looks like a good change overall! Thanks for doing it. I just had two comments on field visibility.
TransientError
force-pushed
the
master
branch
from
16f3d08 to
c529b35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 281
Description of changes:
Using the tokio DuplexStream instead of SimStream.
Because DuplexStream doesn't implement Connection, I created a wrapper for it that does, but I'm open to some alternatives.
By submitting this pull request