Remove cfg(test) on with_stage_variables #713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of the other with_ methods are constrained to test-only, although this method did have a specific comment indicating test-only, so there may have been a reason. Anyway, this commit removes that constraint.
Contributor
|
Can you check the boxes under |
greenwoodcm
approved these changes
Oct 27, 2023
| /// Configures instance with stage variables under `#[cfg(test)]` configurations | ||
| /// Configures instance with stage variables | ||
| /// | ||
| /// This is intended for use in mock testing contexts. |
Contributor
There was a problem hiding this comment.
is this part of the comment still accurate?
Contributor
Author
There was a problem hiding this comment.
I removed the added comments "under ... " because I removed the config annotation - the comment is now in the same form as the other with_ methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#712
Description of changes:
Tis PRt removes the cf(test) constraint from the
with_stage_variablesmethod. constraint.None of the other with_ methods are constrained to test-only, although this method did have a specific comment indicating test-only, so there may have been a reason.
By submitting this pull request