Skip to content

Remove cfg(test) on with_stage_variables #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Remove cfg(test) on with_stage_variables #713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions lambda-http/src/ext/extensions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,9 @@ pub trait RequestExt {
/// These will always be `None` for ALB triggered requests.
fn stage_variables_ref(&self) -> Option<&QueryMap>;

/// Configures instance with stage variables under `#[cfg(test)]` configurations
/// Configures instance with stage variables
///
/// This is intended for use in mock testing contexts.
Copy link
Contributor

@greenwoodcm greenwoodcm Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this part of the comment still accurate?

Copy link
Contributor Author

@bassmanitram bassmanitram Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the added comments "under ... " because I removed the config annotation - the comment is now in the same form as the other with_ methods.

#[cfg(test)]
fn with_stage_variables<V>(self, variables: V) -> Self
where
V: Into<QueryMap>;
Expand Down Expand Up @@ -216,7 +215,6 @@ impl RequestExt for http::Extensions {
.and_then(|StageVariables(vars)| if vars.is_empty() { None } else { Some(vars) })
}

#[cfg(test)]
fn with_stage_variables<V>(self, variables: V) -> Self
where
V: Into<QueryMap>,
Expand Down Expand Up @@ -318,7 +316,6 @@ impl RequestExt for Parts {
self.extensions.stage_variables_ref()
}

#[cfg(test)]
fn with_stage_variables<V>(self, variables: V) -> Self
where
V: Into<QueryMap>,
Expand Down Expand Up @@ -420,7 +417,6 @@ impl<B> RequestExt for http::Request<B> {
self.extensions().stage_variables_ref()
}

#[cfg(test)]
fn with_stage_variables<V>(self, variables: V) -> Self
where
V: Into<QueryMap>,
Expand Down