Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Added integration tests for the HTTP adapter using an HTTP mock server. The mock server simulates the web application and it actually spins up a Hyper server locally so the tests are excercising the majority of the adapter logic, except for the part where we register as a Lambda extension (see note 2 below).
Note
I made a minor change to the
AdapterOptionsstruct to make fields public so that we could initialize the struct from within the tests. Using environment variables for the tests wasn't an option as by default all tests run in parallel and modifying env variables in one test affects the rest of them.Note 2
I tried to simulate the Lambda Extensions API locally as well and made really good progress, but I ended up stuck with some tokio threads hanging and not being terminated gracefully when the tests finished. I kept that work on a local branch, may push it in the future if I manage to fix the issue.
Future work
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.