Add AWS_LWA_PORT as a fallback for readiness_check_port.#246
Merged
Add AWS_LWA_PORT as a fallback for readiness_check_port.#246
Conversation
mbfreder
suggested changes
Jun 26, 2023
Contributor
mbfreder
left a comment
mbfreder
left a comment
There was a problem hiding this comment.
Thank you for your contribution. Could you please add tests for this?
Contributor
Author
|
Updated the test, PTAL. Thanks! |
mbfreder
approved these changes
Jun 28, 2023
Contributor
|
This looks good. Could you fix the small linting issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #245
Description of changes: Add
AWS_LWA_PORTas a fallback forreadiness_check_port.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.