Pass Lambda Context to web app in a new header#248
Merged
Conversation
Contributor
|
Thanks for the contribution. Could you add one test to check if the new header is present? You can do it when creating the mock server. when.method(GET)
.path("/")
.header_exists("x-amzn-lambda-context"); |
Contributor
Author
Done, thanks. |
bnusunny
approved these changes
Jul 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #244
Description of changes:
Made Lambda Context available to web apps in a new header (x-amzn-lambda-context).
Note : The implementation broke some tests because the
LambdaRequestobject used to send the request to the mock server doesn't have a lambda context, resulting in an error ("Request did not contain a lambda context") when"let lambda_context = &event.lambda_context();"is called. I fixed this by replacingLambdaRequestwithRequest, which allows adding the lambda context.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.