Skip to content

warn when configured header not found#479

Merged
bnusunny merged 1 commit intoaws:mainfrom
mxfactorial:477-warn-absent-configured-header
Jul 18, 2024
Merged

warn when configured header not found#479
bnusunny merged 1 commit intoaws:mainfrom
mxfactorial:477-warn-absent-configured-header

Conversation

@mxfactorial
Copy link
Copy Markdown
Contributor

Issue #, if available:

#477

Description of changes:

missed #478 code review

warn when:

  1. AWS_LWA_AUTHORIZATION_SOURCE=auth-token
  2. .with_header("other-token", "Bearer token")

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Copy Markdown
Contributor

@bnusunny bnusunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnusunny bnusunny merged commit a0fa62f into aws:main Jul 18, 2024
@mxfactorial mxfactorial deleted the 477-warn-absent-configured-header branch July 18, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants