don't append trailing '?' when query string is empty#657
Merged
Conversation
📊 Benchmark ComparisonBenchmark Details
|
bnusunny
approved these changes
Mar 12, 2026
Contributor
bnusunny
left a comment
bnusunny
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
When
parts.uri.query()returnsSome("")from an API Gateway v2 event with an emptyrawQueryString.app_url.set_query(Some(""))appends a bare?to the forwarded URL.This change filters out empty query strings so that
set_query(None)is called instead, which produces a clean URL with no trailing?. Non-empty query strings are unaffected.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.