fix: ensure benchmark results are uploaded and commented on failure#673
Merged
fix: ensure benchmark results are uploaded and commented on failure#673
Conversation
- Add 'if: always()' to save and upload benchmark results steps so artifacts are available even when the benchmark fails - Update benchmark-comment workflow to only trigger when the benchmark run concludes with failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
if: always()to the "Save benchmark results" and "Upload benchmark results" steps so artifacts are available even when the benchmark job fails.failure, ensuring regression comments are posted on failed runs.Why
Previously, if the benchmark step failed (e.g. due to a regression), the results artifact was never uploaded, so the comment workflow had nothing to download and couldn't post the regression notice on the PR.