Cherry-pick support for CMake 4.0 to fips-2024-09-27 #2277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description of changes: [CMake 4.0](https://cmake.org/cmake/help/latest/release/4.0.html) is coming out soon and requires cmake_minimum_required to be at least 3.5: > Compatibility with versions of CMake older than 3.5 has been removed. Calls to [cmake_minimum_required()](https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html#command:cmake_minimum_required) or [cmake_policy()](https://cmake.org/cmake/help/latest/command/cmake_policy.html#command:cmake_policy) that set the policy version to an older value now issue an error The [common runtime](awslabs/aws-c-common#1178) and [s2n-tls](aws/s2n-tls#4899) upgraded to 3.9 last year. ### Call-outs: This will break any customer using CMake version less than 3.5 which was [released in December https://github.com/Kitware/CMake/releases/tag/v3.5.0) By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
skmcgrail
approved these changes
Mar 18, 2025
darylmartin100
approved these changes
Mar 18, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fips-2024-09-27 #2277 +/- ##
===================================================
- Coverage 78.60% 78.59% -0.01%
===================================================
Files 585 585
Lines 100525 100526 +1
Branches 14250 14253 +3
===================================================
- Hits 79014 79010 -4
- Misses 20874 20880 +6
+ Partials 637 636 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This code does not modify the FIPS boundary.
Cherry-picks:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.