[cherry-pick] Add back X509_STORE_get_verify_cb and X509_STORE_set_lookup_crls_cb #2587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ws#2581) ### Issues: Addresses V1681685441 ### Description of changes: The following symbols were removed as part of two upstream merges in 2024, which broke the ability to build the Azure SDK for C++ on both main and in the FIPS 3.x release. This was previously supported in the FIPS 2.x line, and was a bit unexpected. This partially reverts these commits to include back the necessary symbols. X509_STORE_get_verify_cb: aws@884ad00 X509_STORE_set_lookup_crls_cb: aws@d0c25d1 aws#1527 and aws#1621 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. (cherry picked from commit a22d1a3)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fips-2024-09-27 #2587 +/- ##
===================================================
+ Coverage 78.61% 78.63% +0.01%
===================================================
Files 585 585
Lines 100723 100745 +22
Branches 14270 14274 +4
===================================================
+ Hits 79188 79224 +36
+ Misses 20899 20885 -14
Partials 636 636 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
smittals2
approved these changes
Jul 31, 2025
samuel40791765
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks #2581
This change is outside of the FIPS module and does not affect its hash.
Issues:
Addresses V1681685441
Description of changes:
The following symbols were removed as part of two upstream merges in
2024, which broke the ability to build the Azure SDK for C++ on both
main and in the FIPS 3.x release. This was previously supported in the
FIPS 2.x line, and was a bit unexpected. This partially reverts these
commits to include back the necessary symbols.
X509_STORE_get_verify_cb:
884ad00
X509_STORE_set_lookup_crls_cb:
d0c25d1
#1527 and
#1621
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.