Cherry-pick TLS transfer serialization changes to FIPS 3.x branch #2672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`previous_client_finished` has to grow past 12 since it's also used for
1.3 now. This breaks the original SSL Transfer assumption and we'll have
to bump the version while adding corresponding logic to account for the
updated size. I've regenerated the SSL Transfer bytes for the round trip
tests and also added a test for that as well. We're not bumping the
version number here since it's a pretty minuscule change. This doesn't
break compatibility with us parsing older versions of AWS-LC SSL
Transfers, but older versions of AWS-LC won't be able to parse the new
version.
(cherry picked from commit fa1c6c0)
Addresses CryptoAlg-3221, CryptoAlg-3220, CryptoAlg-3219, CryptoAlg-3218, CryptoAlg-3217, CryptoAlg-3216, CryptoAlg-3215, CryptoAlg-3214, CryptoAlg-3212, CryptoAlg-3211 This pull request addresses and improves the experimental TLS transfer serialization feature. Primarily focusing on performance of restored connections for the SSLBuffer by improving the serialization format, and hardens the checking of the data structures on deserialization. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. (cherry picked from commit 26da017)
Static analysis actually found something where the same condition was being checked twice. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. (cherry picked from commit 6457caf)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fips-2024-09-27 #2672 +/- ##
===================================================
- Coverage 78.63% 78.58% -0.06%
===================================================
Files 585 585
Lines 100745 101021 +276
Branches 14275 14310 +35
===================================================
+ Hits 79222 79388 +166
- Misses 20886 20998 +112
+ Partials 637 635 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Curl is setting a buffer size larger than the maximum buffer length that AWS-LC allows. `0x401e * 4` is inherently `65656`, which is larger than the allowed `65535` and AWS-LC directly uses the largest size available (`65535`) if the consuming application sets a value larger than that. This limitation's due to a buffer size we inherited from upstream. I've tested against the test that was failing for curl and the test seems to pass now (for all instances I've ran it). Running `pytest -n auto -v ./http/test_10_proxy.py::TestProxy::test_10_08_upload_seq_large -rA` had been failing 5/10 times prior to this change and it passes every time that I run it now. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. (cherry picked from commit 78ada21)
justsmth
approved these changes
Sep 10, 2025
samuel40791765
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
verify_resultfield as an optional field.This is being done in order to make it more seamless to migrate from the 3.x to the future 4.x release and incorporate the serialization improvements.
This changes does not impact FIPS module boundary.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.