Skip to content

Conversation

@justsmth
Copy link
Contributor

@justsmth justsmth commented Oct 6, 2025

Cherry-pick onto fips-2024-09-27. Original PR for main:

I needed to resolve a merge conflict for the ssl_test.cc changes.


Issues:

n/a

Description of changes:

This change adds ECDSA P521 to our list of supported certificate verification algorithms in client Hello.

Call-outs:

n/a

Testing:

CI for automated tests. Manual test to confirm signature_algorithms extension contents before/after:

./build/tool/bssl s_client -connect kms.us-east-1.amazonaws.com:443

Client Hello before:

Screenshot 2025-07-23 at 5 52 15 PM

Client Hello after:

Screenshot 2025-07-23 at 5 47 51 PM

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner October 6, 2025 20:40
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.58%. Comparing base (f1255f8) to head (2142269).

Files with missing lines Patch % Lines
ssl/ssl_test.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           fips-2024-09-27    #2731   +/-   ##
================================================
  Coverage            78.57%   78.58%           
================================================
  Files                  585      585           
  Lines               101047   101047           
  Branches             14311    14312    +1     
================================================
+ Hits                 79400    79407    +7     
+ Misses               21009    21003    -6     
+ Partials               638      637    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WillChilds-Klein WillChilds-Klein merged commit 086b1b7 into aws:fips-2024-09-27 Oct 6, 2025
72 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants