Skip to content

Refactor PQDSA_KEY set_raw functions to use goto-err cleanup#2993

Merged
dkostic merged 1 commit into
aws:mainfrom
dkostic:pqdsa-cleanup
Feb 20, 2026
Merged

Refactor PQDSA_KEY set_raw functions to use goto-err cleanup#2993
dkostic merged 1 commit into
aws:mainfrom
dkostic:pqdsa-cleanup

Conversation

@dkostic
Copy link
Copy Markdown
Contributor

@dkostic dkostic commented Feb 13, 2026

Description of changes:

Consolidates error handling, fixes memory leaks on reuse, and
ensures atomic key assignment (no partial state on failure).

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.14286% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.32%. Comparing base (24d4627) to head (21103bb).

Files with missing lines Patch % Lines
crypto/fipsmodule/pqdsa/pqdsa.c 87.14% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2993   +/-   ##
=======================================
  Coverage   78.31%   78.32%           
=======================================
  Files         689      689           
  Lines      120967   120970    +3     
  Branches    16963    16958    -5     
=======================================
+ Hits        94735    94745   +10     
+ Misses      25334    25329    -5     
+ Partials      898      896    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkostic dkostic merged commit 0430b7d into aws:main Feb 20, 2026
432 of 439 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants