Clean up sensitive stack buffers and minor fixes in PKCS#8#3067
Merged
Clean up sensitive stack buffers and minor fixes in PKCS#8#3067
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3067 +/- ##
==========================================
- Coverage 78.16% 78.15% -0.01%
==========================================
Files 689 689
Lines 121628 121632 +4
Branches 16981 16980 -1
==========================================
- Hits 95070 95066 -4
- Misses 25675 25681 +6
- Partials 883 885 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WillChilds-Klein
previously approved these changes
Mar 4, 2026
geedo0
previously approved these changes
Mar 5, 2026
ae7646a to
fb5dea6
Compare
fb5dea6 to
643f72d
Compare
sgmenda
approved these changes
Mar 6, 2026
WillChilds-Klein
approved these changes
Mar 11, 2026
6981587 to
879160d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Minor hardening and cleanup in
crypto/pkcs8/pkcs8.c:pkcs12_pbe_cipher_initandpkcs12_key_gen.plaintext_len > INT_MAXguard inPKCS8_marshal_encrypted_private_keyfor consistency withpkcs8_pbe_decrypt.None of these are practically exploitable — just defense-in-depth hygiene.
Testing:
Existing tests cover the affected code paths. No behavioral changes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.