Add bounds checks for size_t to int truncation in RSA_METHOD calls#3084
Merged
Add bounds checks for size_t to int truncation in RSA_METHOD calls#3084
size_t to int truncation in RSA_METHOD calls#3084Conversation
size_t to int truncation in RSA_METHOD calls
nebeid
approved these changes
Mar 10, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3084 +/- ##
==========================================
+ Coverage 78.11% 78.13% +0.01%
==========================================
Files 689 689
Lines 121596 121612 +16
Branches 16981 16986 +5
==========================================
+ Hits 94981 95016 +35
+ Misses 25729 25714 -15
+ Partials 886 882 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sgmenda
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
The
RSA_METHODfunction pointers (sign_raw,verify_raw,encrypt,decrypt) acceptint max_outparameters for OpenSSL API compatibility,but the calling functions receive
max_outassize_t.In practice,
max_outis bounded by the RSA modulus size and would neverapproach
INT_MAX. These checks are a defense-in-depth measure. The errorcode (
ERR_R_OVERFLOW) and error-handling pattern (*out_len = 0; return 0)are consistent with existing overflow checks in the codebase.
Testing:
Existing RSA tests cover the normal code paths. The new bounds checks
only trigger for
max_outvalues exceedingINT_MAX, which cannot occurwith valid RSA key sizes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.