Skip to content

Correct types finished-based APIs for TLS 1.3#3087

Merged
samuel40791765 merged 2 commits intoaws:mainfrom
samuel40791765:ssl-finished-tls13-fix
Mar 16, 2026
Merged

Correct types finished-based APIs for TLS 1.3#3087
samuel40791765 merged 2 commits intoaws:mainfrom
samuel40791765:ssl-finished-tls13-fix

Conversation

@samuel40791765
Copy link
Contributor

Properly return false instead of ssl_hs_error in tls13_*_finished

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.19%. Comparing base (8fbad8c) to head (6d91a82).

Files with missing lines Patch % Lines
ssl/tls13_both.cc 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3087      +/-   ##
==========================================
+ Coverage   78.16%   78.19%   +0.03%     
==========================================
  Files         689      689              
  Lines      121821   121821              
  Branches    16995    16995              
==========================================
+ Hits        95216    95254      +38     
+ Misses      25720    25683      -37     
+ Partials      885      884       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samuel40791765 samuel40791765 enabled auto-merge (squash) March 16, 2026 17:20
@samuel40791765 samuel40791765 merged commit 107e67d into aws:main Mar 16, 2026
453 of 456 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants