TLS 1.3 Transfer Support #891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could this PR be split into smaller pieces? |
Member
Author
The majority of changes here are formatting changes to files I touched because they didn’t actually conform to the clang-format file definition. The actual change excluding the fuzzing files is fairly small. |
skmcgrail
force-pushed
the
tls13
branch
3 times, most recently
from
6633355 to
8d4cc00
Compare
skmcgrail
force-pushed
the
tls13
branch
3 times, most recently
from
c9d6d78 to
607b6bb
Compare
andrewhop
reviewed
Mar 23, 2023
skmcgrail
force-pushed
the
tls13
branch
2 times, most recently
from
cd12ec0 to
21390bf
Compare
andrewhop
reviewed
Mar 28, 2023
samuel40791765
previously approved these changes
Mar 28, 2023
Member
Author
|
Will rebase again once #912 is merged in so we can have valgrind validation for libssl. |
skmcgrail
commented
Mar 29, 2023
skmcgrail
force-pushed
the
tls13
branch
2 times, most recently
from
073e9da to
3783f4b
Compare
skmcgrail
force-pushed
the
tls13
branch
2 times, most recently
from
7ad4a90 to
e7c6fc5
Compare
skmcgrail
force-pushed
the
tls13
branch
2 times, most recently
from
b1c32c8 to
d6e544b
Compare
torben-hansen
approved these changes
Apr 3, 2023
samuel40791765
approved these changes
Apr 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves CryptoAlg-1653
Description of changes:
Add support for TLS 1.3 for the SSL transfer feature, which previously only support TLS 1.2 connections.
Call-outs:
I've added tls_transfer.asn as a way to better document the TLS transfer encoding using the ASN.1 module syntax definition. Should hopefully make it easier to track the definitions going forward. There is a handy visual studio code plugin that can be used to give syntax validation and highlighting as well.
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and
the ISC license.